Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sRGB option to 2D RawTexture #12553

Merged
merged 4 commits into from
May 21, 2022
Merged

Add sRGB option to 2D RawTexture #12553

merged 4 commits into from
May 21, 2022

Conversation

kircher1
Copy link
Contributor

No description provided.

sebavan
sebavan approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one feels like plumbing :-) thanks a lot @kircher1

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12553/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12553/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12553/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12553/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12553/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12553/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12553/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12553/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12553/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12553/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12553/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12553/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12553/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12553/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12553/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12553/merge#BCU1XR#0

@sebavan sebavan merged commit 9cc3034 into BabylonJS:master May 21, 2022
@kircher1 kircher1 deleted the users/briank/raw-texture-srgb branch August 26, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
enhancement rendering engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kircher1 @sebavan