Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NME TBNBlock world input doesn't work if connected to a vertex node #12519

Merged
merged 1 commit into from
May 12, 2022

Conversation

MiikaH
Copy link
Contributor

@MiikaH MiikaH commented May 12, 2022

This fixes: https://forum.babylonjs.com/t/nme-tbnblock-world-input-doesnt-work-if-connected-to-another-vertex-node-block/30322

Whole TNBBlock is switched to Fragment target type as it already kind of was. And moved to Fragment nodes folder where it now belongs.

With this fix in place Playground example #VL1FPT#8 should now work without a shader error.

…ode instead of input block.

Switch TBNBlock to Fragment target for future consistency and move to appropriate folder.
@sebavan sebavan requested a review from Popov72 May 12, 2022 17:40
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan added bug nme Node Material Editor labels May 12, 2022
@sebavan sebavan merged commit c119cc9 into BabylonJS:master May 12, 2022
@MiikaH MiikaH deleted the Fix-TBNBlock-World-Input branch May 13, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nme Node Material Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants