Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scissor Doc #12518

Merged
merged 2 commits into from
May 12, 2022
Merged

Fix Scissor Doc #12518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6486826
Fix Scissor Doc
sebavan May 12, 2022
15c9f1f
fix engine factory returning ThinEngine
sebavan May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/dev/core/src/Engines/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,7 +1082,7 @@ export class Engine extends ThinEngine {

/**
* Executes a scissor clear (ie. a clear on a specific portion of the screen)
* @param x defines the x-coordinate of the top left corner of the clear rectangle
* @param x defines the x-coordinate of the bottom left corner of the clear rectangle
* @param y defines the y-coordinate of the corner of the clear rectangle
* @param width defines the width of the clear rectangle
* @param height defines the height of the clear rectangle
Expand All @@ -1096,7 +1096,7 @@ export class Engine extends ThinEngine {

/**
* Enable scissor test on a specific rectangle (ie. render will only be executed on a specific portion of the screen)
* @param x defines the x-coordinate of the top left corner of the clear rectangle
* @param x defines the x-coordinate of the bottom left corner of the clear rectangle
* @param y defines the y-coordinate of the corner of the clear rectangle
* @param width defines the width of the clear rectangle
* @param height defines the height of the clear rectangle
Expand Down
3 changes: 1 addition & 2 deletions packages/dev/core/src/Engines/engineFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { Engine } from "./engine";
import { NullEngine } from "./nullEngine";
import type { ThinEngine } from "./thinEngine";
import { WebGPUEngine } from "./webgpuEngine";

/**
Expand All @@ -13,7 +12,7 @@ export class EngineFactory {
* @param options Defines the options passed to the engine to create the context dependencies
* @returns a promise that resolves with the created engine
*/
public static CreateAsync(canvas: HTMLCanvasElement, options: any): Promise<ThinEngine> {
public static CreateAsync(canvas: HTMLCanvasElement, options: any): Promise<Engine> {
return WebGPUEngine.IsSupportedAsync.then((supported) => {
if (supported) {
return WebGPUEngine.CreateAsync(canvas, options);
Expand Down