Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getPositionData missing slice of vertex positions #12375

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

BlakeOne
Copy link
Contributor

@BlakeOne BlakeOne commented Apr 11, 2022

Change getPositionData to slice the vertex position array after getting it from the geometry to fix the issue that when getPositionData is called repeatedly it only worked correctly the first time.

PG: https://playground.babylonjs.com/#SYQW69#1034
Forum: https://forum.babylonjs.com/t/bug-mesh-getpositiondata-blows-up-everytime-you-run-it/29246

@BlakeOne BlakeOne changed the title fix: getPositionData missing slice of vertex positions fix getPositionData to slice fetched vertex positions array Apr 11, 2022
@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@BlakeOne BlakeOne changed the title fix getPositionData to slice fetched vertex positions array fix: getPositionData missing slice of vertex positions Apr 11, 2022
@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12375/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12375/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12375/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12375/merge#BCU1XR#0

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12375/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12375/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12375/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12375/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12375/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12375/merge#BCU1XR#0

@RaananW RaananW merged commit f94bdc9 into BabylonJS:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants