Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NME PerturbNormal block: add support for object space sampling mode #13420

Closed
Popov72 opened this issue Jan 8, 2023 · 0 comments · Fixed by #13501
Closed

NME PerturbNormal block: add support for object space sampling mode #13420

Popov72 opened this issue Jan 8, 2023 · 0 comments · Fixed by #13501
Assignees
Labels
new feature nme Node Material Editor
Milestone

Comments

@Popov72
Copy link
Contributor

Popov72 commented Jan 8, 2023

See https://forum.babylonjs.com/t/read-texture-in-object-space-in-nme/37182

In this mode, we would need to set the OBJECTSPACE_NORMALMAP define and pass the normalMatrix to the shader code. Which in turns means we have to add a new world matrix entry to the PerturbNormal block:

https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Materials/PBR/pbrBaseMaterial.ts#L2001-L2004

@Popov72 Popov72 added new feature nme Node Material Editor labels Jan 8, 2023
@thomlucc thomlucc assigned thomlucc and sebavan and unassigned thomlucc Jan 18, 2023
@thomlucc thomlucc added this to the 6.0 milestone Jan 18, 2023
sebavan added a commit to sebavan/Babylon.js that referenced this issue Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature nme Node Material Editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants