Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android openssl atomic bugfix with ndk update #4751

Merged
merged 1 commit into from
May 20, 2022
Merged

Android openssl atomic bugfix with ndk update #4751

merged 1 commit into from
May 20, 2022

Conversation

talregev
Copy link
Contributor

@talregev talregev commented May 20, 2022 •
edited
Loading

Android openssl atomic bugfix with ndk update.
Fixes microsoft/vcpkg#24021
Fixes #4696

@talregev talregev force-pushed the TalR/test_android_openssl_fix_ndk branch 2 times, most recently from 0d38e24 to 68524dc Compare May 20, 2022 18:39
@talregev
Copy link
Contributor Author

talregev commented May 20, 2022 •
edited
Loading

@AenBleidd This PR is fix the openssl atomic problem with update of clang (update ndk). I think this fix is better and we should cancel your PR to vcpkg.

@talregev talregev force-pushed the TalR/test_android_openssl_fix_ndk branch from 68524dc to a8883c8 Compare May 20, 2022 18:51
@talregev
Copy link
Contributor Author

talregev commented May 20, 2022 •
edited
Loading

@AenBleidd This fix interduce a new problem. That vcpkg compile arm with neon, even if the neon set to False.
I want to investigate this problem. It ok if you put your vcpkg PR on draft?

I choose another ndk without this problem.

@talregev talregev force-pushed the TalR/test_android_openssl_fix_ndk branch from a8883c8 to cbd38d4 Compare May 20, 2022 22:18
@talregev talregev mentioned this pull request May 20, 2022
Closed
@talregev talregev changed the title [Test] android openssl fix with ndk update Android openssl fix with ndk update May 20, 2022
@talregev talregev changed the title Android openssl fix with ndk update Android openssl atomic bugfix with ndk update May 20, 2022
@talregev talregev marked this pull request as ready for review May 20, 2022 22:50
@AenBleidd AenBleidd self-assigned this May 20, 2022
@AenBleidd AenBleidd added this to the Android Unreleased milestone May 20, 2022
@AenBleidd AenBleidd merged commit 887fc64 into BOINC:master May 20, 2022
@talregev talregev deleted the TalR/test_android_openssl_fix_ndk branch May 20, 2022 23:25
@AenBleidd AenBleidd mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AenBleidd AenBleidd AenBleidd approved these changes

Assignees

@AenBleidd AenBleidd

Labels
P: Major PR: Bugfix
Projects
Client/Manager
Archived in project
Android Client/Manager
Archived in project
Milestone
Client 7.22.0
Development

Successfully merging this pull request may close these issues.

[Android][vcpkg] Remove vcpkg pinning [openssl] build failure on Android x86
2 participants
@talregev @AenBleidd