[openssl] Fix build for Android x86. #24801
Conversation
OpenSSL3 uses atomics that are broken on clang for Android x86. This commit fixes the build by disabling usage of these atomics on Android x86 only. This fixes microsoft#24021. Signed-off-by: Vitalii Koshura <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This PR is tested using overlay ports here: BOINC/boinc#4749 |
Adela0814
added
info:reviewed
|
follow |
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
error: checked-in files for openssl have changed but the version was not updated
version: 3.0.3#3
old SHA: f72e602e3fde9d592c2f8d01c4ca0ed21c4df63b
new SHA: 03f8e7e77fd71aaf31af19896c07deaa58b02662
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
|
Please hold for this fix. I want to investigate another solution. |
There was a problem hiding this comment.
There is another solution for update the ndk version (the clang version) and it solve the bug.
@AenBleidd please put this PR on draft.
|
@BillyONeal, sorry for 'not nice' words. Didn't know you have such a policy. Next time I'll try to be more polite. |
Please review my PR: |
Because of your comment I understand the problem. |
No problem! |
I fix #24021 issue in this PR BOINC/boinc#4751 without this PR fix. |
|
@talregev, congratulations with the fix. |
OpenSSL3 uses atomics that are broken on clang for Android x86.
This commit fixes the build by disabling usage of these atomics on Android x86 only.
This fixes #24021.
Signed-off-by: Vitalii Koshura [email protected]