Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Android openssl fix #4750

Closed

Conversation

talregev
Copy link
Contributor

@talregev talregev commented May 20, 2022

Test Android openssl fix.

@AenBleidd
Copy link
Member

This is a duplicate of #4749. Why do you need to test it again?
And btw. your test is not correct because you're still overriding vcpkg to use OpenSSL 1.1.1* instead of OpenSSL3.*

@talregev
Copy link
Contributor Author

talregev commented May 20, 2022

This is a duplicate of #4749. Why do you need to test it again

I think this is the way we should test the fix.

your test is not correct because you're still overriding vcpkg to use OpenSSL 1.1.1* instead of OpenSSL3.*

I agree. I will change it here.

@talregev
Copy link
Contributor Author

talregev commented May 20, 2022

After your vcpkg PR will merge, I can change the link again, and This PR will ready to merge into boinc master.

@talregev talregev force-pushed the TalR/test_android_openssl_fix branch 3 times, most recently from 6fa4797 to 74fee96 Compare May 20, 2022 17:35
@talregev talregev force-pushed the TalR/test_android_openssl_fix branch from 74fee96 to 742a9b8 Compare May 20, 2022 17:45
@talregev talregev closed this May 20, 2022
@talregev talregev deleted the TalR/test_android_openssl_fix branch May 20, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants