-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor adapter to move FileSettings from XMLAdapter to XMLConfig #593
Conversation
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I set up the settings nicely the last time so this wasn't as much work as I was expecting!
Minor changes needed please @Tom-Kingstone
@Tom-Kingstone to confirm, the following actions are now queued:
|
Co-authored-by: Fraser Greenroyd <[email protected]>
@Tom-Kingstone to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and aligns nicely @Tom-Kingstone - great work
@Tom-Kingstone just to let you know, I have provided a |
FAO: @FraserGreenroyd The check they wish to have dispensation on is installer. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 18073278039 |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd I have now provided a passing check on reference |
Issues addressed by this PR
Closes #592
XMLAdapter
and placed inXMLConfig
.XMLConfig
is now anIXMLConfig
and any future configs must contain a file settings attribute.config.File
rather than_fileSettings