Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor adapter to move FileSettings from XMLAdapter to XMLConfig #593

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

Tom-Kingstone
Copy link
Contributor

Issues addressed by this PR

Closes #592

  • File settings attribute removed from XMLAdapter and placed in XMLConfig.
  • XMLConfig is now an IXMLConfig and any future configs must contain a file settings attribute.
  • CRUD methods have been updated to use config.File rather than _fileSettings

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I set up the settings nicely the last time so this wasn't as much work as I was expecting!

Minor changes needed please @Tom-Kingstone

XML_Adapter/XMLAdapter.cs Show resolved Hide resolved
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning

XML_Adapter/XMLAdapter.cs Outdated Show resolved Hide resolved
XML_Adapter/XMLAdapter.cs Outdated Show resolved Hide resolved
@Tom-Kingstone Tom-Kingstone changed the title Refactor adapter to be in line with other adapters Refactor adapter to mofe FileSettings from XMLAdapter to XMLConfig Oct 25, 2023
@Tom-Kingstone Tom-Kingstone changed the title Refactor adapter to mofe FileSettings from XMLAdapter to XMLConfig Refactor adapter to move FileSettings from XMLAdapter to XMLConfig Oct 25, 2023
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 25, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and aligns nicely @Tom-Kingstone - great work

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2023

@Tom-Kingstone just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on SAP_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is installer.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 18073278039

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 18073278039

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 26, 2023

@FraserGreenroyd I have now provided a passing check on reference 18073278039 as requested.

@FraserGreenroyd FraserGreenroyd merged commit f9f3d34 into develop Oct 26, 2023
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the XML_Toolkit-#592-RefactorAdapter branch October 26, 2023 10:07
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor adapter to use action config instead of file settings.
2 participants