Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor adapter to use action config instead of file settings. #592

Closed
4 tasks done
Tom-Kingstone opened this issue Oct 25, 2023 · 0 comments · Fixed by #593
Closed
4 tasks done

Refactor adapter to use action config instead of file settings. #592

Tom-Kingstone opened this issue Oct 25, 2023 · 0 comments · Fixed by #593
Assignees
@Tom-Kingstone
Labels
type:compliance Non-conforming to code guidelines

Comments

@Tom-Kingstone
Copy link
Contributor

Tom-Kingstone commented Oct 25, 2023 •
edited
Loading

Broken rules:

In order to be in line with other toolkit adapters, the adapter needs to be refactored to move the file settings from a private attribute in the XMLAdapter to the XML action configs instead.

Suggestions to restore compliance:

  • Remove file settings attribute from XMLAdapter.
  • Add file settings attribute to XMLConfig.
  • Create new interface IXMLConfig to force file settings on all xml configs
  • Update CRUD methods to use the refactored attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor adapter to move FileSettings from XMLAdapter to XMLConfig BHoM/XML_Toolkit
1 participant
@Tom-Kingstone