-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter: added remaining object serialisation #152
Adapter: added remaining object serialisation #152
Conversation
…methods to more easily use ILadybugTools objects.
…imulationResult logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget your copyright headers 😉
@BHoMBot check compliance |
@Tom-Kingstone to confirm, the following actions are now queued:
|
Co-authored-by: Fraser Greenroyd <[email protected]>
@Tom-Kingstone fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix copyright headers ref. 19104709440 |
@Tom-Kingstone I have queued up your request to fix copyright headers. There are 2 requests in the queue ahead of you. |
@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made. |
@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
@Tom-Kingstone to confirm, the following actions are now queued:
|
@BHoMBot please could this check for versioning pass? |
@Tom-Kingstone sorry, I didn't understand. |
@BHoMBot check versioning :) |
@Tom-Kingstone to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Tom-Kingstone happy to deploy for alpha testing
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is installer. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19106541863 |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #144
ExternalComfort
,SimulationResult
,Shelter
, andTypology
have been added to the adapter to allow conversion to python-readable json, ready to be used in the engine methods.The adapter can also convert
Point
s to ladybugPoint3D
s, though this isn't accessible other than when converting Shelters.Also added support for converting multiple objects to json.
Test files
Changelog
Additional comments