Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter: added remaining object serialisation #152

Merged

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #144

ExternalComfort, SimulationResult, Shelter, and Typology have been added to the adapter to allow conversion to python-readable json, ready to be used in the engine methods.
The adapter can also convert Points to ladybug Point3Ds, though this isn't accessible other than when converting Shelters.

Also added support for converting multiple objects to json.

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:feature New capability or enhancement label Nov 28, 2023
@Tom-Kingstone Tom-Kingstone self-assigned this Nov 28, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget your copyright headers 😉

LadybugTools_Adapter/Convert/Geometry/Shelter.cs Outdated Show resolved Hide resolved
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 19104709440

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot fix copyright headers ref. 19104709440

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone I have queued up your request to fix copyright headers. There are 2 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made.

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check versioning

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot please could this check for versioning pass?

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check versioning :)

Copy link

bhombot-ci bot commented Nov 28, 2023

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 28, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 28, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 28, 2023

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 28, 2023

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Tom-Kingstone happy to deploy for alpha testing

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: unit-tests

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link

bhombot-ci bot commented Nov 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is installer.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19106541863

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 19106541863

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 19106541863 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 5fb194e into develop Nov 28, 2023
13 checks passed
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#144-AddMoreObjectsToAdapter branch November 28, 2023 17:52
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more ILadybugTools objects to adapter pushing and pulling
3 participants