Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more ILadybugTools objects to adapter pushing and pulling #144

Closed
Tom-Kingstone opened this issue Nov 24, 2023 · 0 comments · Fixed by #152
Closed

Add more ILadybugTools objects to adapter pushing and pulling #144

Tom-Kingstone opened this issue Nov 24, 2023 · 0 comments · Fixed by #152
Assignees
@Tom-Kingstone
Labels
type:feature New capability or enhancement

Comments

@Tom-Kingstone
Copy link
Contributor

Description:

Currently, the following objects are not yet supported by the adapter:

  • ExternalComfort
  • Shelter
  • SimulationResult
  • Typology

Ideally, these would be supported so the adapter can be used in the engine methods - Therefore To and From BHoM methods should be added to Convert in the adapter supporting these.

This issue also covers updating the engine methods to use the adapter for serialisation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tom-Kingstone Tom-Kingstone

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapter: added remaining object serialisation BHoM/LadybugTools_Toolkit
1 participant
@Tom-Kingstone