This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Change display of program cards in group3 & update stories to include 4 cards #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaLyubin
reviewed
Feb 27, 2020
| @@ -3,7 +3,11 @@ | |||
| <!-- prettier-ignore --> | |||
| | Version | Description | | |||
| |---------|-------------| | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Left this after conflict resolving 🙈
OlgaLyubin
reviewed
Feb 27, 2020
| @@ -11,7 +11,7 @@ export const sentenceCase = text => | |||
| .charAt(0) | |||
| .toUpperCase() + text.substring(1); | |||
|
|
|||
| export const stateTypes = ['onDemand', 'live', 'next']; | |||
| export const stateTypes = ['live', 'onDemand', 'onDemand', 'next']; | |||
There was a problem hiding this comment.
Since now we have two onDemands here, in ProgramCard test should render correctly for ${state} where we go through each state type, we will have two identical snapshots for 'onDemand'. Can you please fix that to avoid repetition?
There was a problem hiding this comment.
Nice catch, fixed now
OlgaLyubin
approved these changes
Mar 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3134
Overall change:
Changes the grid layout of the component in group 3 from having the 4th card overflow to another row to having a 2x2 layout instead. Also updated stories to have 4 cards rather than 3.
Originally we were to hide a card so the layout would be:
Now UX have agreed on this layout so we don't hide any information just on one breakpoint:
Code changes:
group3ofprogramCardGridPropsfrom 2 to 3 in order to make 2x2 layout.onDemandtwice tostateTypesto add another card easily to stories and changed the order to be correct.