Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Radio Schedules: Hide oldest on Demand card on Group 3 #3134

Closed
1 task done
tochwill opened this issue Feb 13, 2020 · 1 comment · Fixed by #3184
Closed
1 task done

Radio Schedules: Hide oldest on Demand card on Group 3 #3134

tochwill opened this issue Feb 13, 2020 · 1 comment · Fixed by #3184
Assignees
Labels
radio-schedules ux To be reviewed by UX before merging ws-home Tasks for the WS Home Team

Comments

@tochwill
Copy link
Contributor

tochwill commented Feb 13, 2020

Is your feature request related to a problem? Please describe.
The v1 designs for radio schedules do not include the carousel. Instead, we stack 4 cards on breakpoints lower than group 3, show 3 cards in a grid and hide the 3rd card on group 3, and show all 4 in a grid on breakpoints greater than group 3.

Describe the solution you'd like

  • Add logic to be able to hide a card between these breakpoints, based on a prop we can pass in within Radio Schedules.

  • Update the Psammead storybook stories to show 4 programmes.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
At viewport 600-1007px only three cards should be shown in the radio schedule component.

Dev insight: Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@tochwill tochwill added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team radio-schedules labels Feb 13, 2020
@tochwill tochwill self-assigned this Feb 13, 2020
@tochwill tochwill removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Feb 17, 2020
@tochwill tochwill removed their assignment Feb 18, 2020
@tochwill tochwill changed the title Radio Schedules: Hide 3rd card on Group 3 Radio Schedules: Hide oldest on Demand card on Group 3 Feb 19, 2020
@hotinglok hotinglok self-assigned this Feb 19, 2020
@tochwill
Copy link
Contributor Author

We've had some discussions around stacking 2 on 2 on this breakpoint rather than hiding one card. Will update later today based on conversation with UX team.

@hotinglok hotinglok added blocked This issue should not be worked on until another internal issue is completed - see desc for details ux To be reviewed by UX before merging labels Feb 26, 2020
@hotinglok hotinglok removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
radio-schedules ux To be reviewed by UX before merging ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants