This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Talos - Bump @bbc/gel-foundations, @bbc/psammead-amp-geo, @bbc/psammead-assets... #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amywalkerdev
added
ws-home
DenisHdz
reviewed
Feb 7, 2020
| "@bbc/psammead-grid": "^1.1.5", | ||
| "@bbc/psammead-section-label": "^3.0.13", | ||
| "@bbc/psammead-grid": "^1.1.6", | ||
| "@bbc/psammead-section-label": "^4.0.0", |
There was a problem hiding this comment.
This change might break the media indicator used in the Most Read, as it will require to add spacings if needed since we've removed them from the Media Indicator.
There was a problem hiding this comment.
Yeah I've just figured that, will close this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 The following packages have been updated:
@bbc/psammead
Details
@bbc/psammead-grid ^1.1.5 → ^1.1.6parentEnableGelGuttersto documentationDetails
@bbc/psammead-media-indicator ^2.6.27 → ^4.0.1scriptto theMediaIndicatorMediaIndicatorWrapperisInlinefor displaying media indicator inline. Remove boolean propindexAlsossince it should be replaced withisInlineDetails
@bbc/psammead-timestamp-container ^2.6.20 → ^2.6.21@bbc/psammead-content-anchor
Details
@bbc/psammead-headings ^3.1.18 → ^3.1.26GEL_SPACING_QUINconstant in theHeadlinedisplaystyles rather than rely on browser default for@bbc/psammead-most-read
Details
@bbc/psammead-grid ^1.1.5 → ^1.1.6parentEnableGelGuttersto documentationDetails
@bbc/psammead-section-label ^3.0.13 → ^4.0.0@bbc/psammead-radio-schedule
Details
@bbc/psammead-styles ^4.2.0 → ^4.3.0Details
@bbc/psammead-assets ^2.12.0 → ^2.13.0GEL_SPACING_DBLconstant inPhotoMediaIconand stories containerDetails
@bbc/psammead-timestamp-container ^2.6.20 → ^2.6.21