Inline Media Indicator #3029
Inline Media Indicator #3029
Conversation
j-pendlebury
force-pushed
the
inline-media-indicator
branch
from
3d28f65 to
6e91f86
Compare
|
@jblaut That IE11 issue is to do with the text itself not being in a RTL script. When I replaced it with arabic text, it displayed correctly: I will open an issue to fix the Storybook test for StoryPromo with index alsos, using the Storybook helper to use the correct localised text for the index alsos. It'd make testing index alsos reflective of reality. |
| @@ -42,54 +49,44 @@ const TimeDuration = styled.time` | |||
| margin: 0 ${GEL_SPACING_HLF}; | |||
| `; | |||
|
|
|||
| const IndexAlsosMediaIndicator = styled.span` | |||
There was a problem hiding this comment.
We will have to also update the IndexAlsos straight after to use the MediaIndicatorWrapper with the isInline prop instead since this IndexAlsosMediaIndicator won't exist anymore.
|
|
||
| MediaIndicator.propTypes = { | ||
| datetime: string, | ||
| duration: string, | ||
| type: oneOf(['video', 'audio', 'photogallery']), | ||
| topStory: bool, | ||
| service: string.isRequired, | ||
| indexAlsos: bool, | ||
| isInline: bool, |
There was a problem hiding this comment.
We should include a small update to the README if we're adding or removing props 😃
packages/components/psammead-media-indicator/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
all fixed now 👍 |
|
Looks good to me. |
Resolves #3019
Overall change:
Add prop to MediaIndicator to be able to use this component inline with text.
Code changes:
isInlineprop to MediaIndicatorIndex Also with
isInline=trueon NewsIndex Also with
isInline=trueon PersianIE11
(with Persian, the behaviour is different on IE11 than Chrome, but I checked on
latestand it's the exact same behaviour)