Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Merge pull request #2995 from bbc/script-link-storybook #2995

Merged
merged 5 commits into from
Jan 23, 2020

Conversation

j-pendlebury
Copy link
Contributor

Resolves #2974

Overall change: Add VisuallyHiddenText to Script Link story.

Psammead story now:

<span>
  <span>Lat</span>
  <span class="VisuallyHiddenText-sc-1yjwwa5-0 jFfEvX">lat</span>
</span>

Simorgh script link:

<span>
  <span aria-hidden="true">Ћир</span>
  <span class="VisuallyHiddenText-sc-1yjwwa5-0 jFfEvX"> Cyrillic </span>
</span>

Code changes:

  • Add VisuallyHiddenText to display variant in ScriptLink story.
  • package-lock, package.json, and CHANGELOG update

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@j-pendlebury j-pendlebury added the ws-home Tasks for the WS Home Team label Jan 23, 2020
@j-pendlebury j-pendlebury self-assigned this Jan 23, 2020
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-pendlebury j-pendlebury changed the title Add VisuallyHiddenText to Script Link Merge pull request #2995 from bbc/script-link-storybook Jan 23, 2020
@j-pendlebury j-pendlebury merged commit 43d41a4 into latest Jan 23, 2020
@j-pendlebury j-pendlebury deleted the script-link-storybook branch January 23, 2020 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script link component's story doesn't match simorgh usage
3 participants