Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Script link component's story doesn't match simorgh usage #2974

Closed
AlistairGempf opened this issue Jan 20, 2020 · 0 comments · Fixed by #2995
Closed

Script link component's story doesn't match simorgh usage #2974

AlistairGempf opened this issue Jan 20, 2020 · 0 comments · Fixed by #2995
Assignees
Labels
bug Something isn't working ws-home Tasks for the WS Home Team

Comments

@AlistairGempf
Copy link
Contributor

Describe the bug
In simorgh, we use the script link component with visually hidden text of the service. We don't have the visually hidden text in the psammead story book, making it less representative when doing a11y testing in psammead.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to script link storybook
  2. Observe the Inspector
  3. Notice the lack of visually hidden text

Expected behaviour
Script link storybook should have visually hidden text.

Additional context
The script link renders all of its children, so should just be a case of adding a VisuallyHiddenText component into the story.

@AlistairGempf AlistairGempf added the bug Something isn't working label Jan 20, 2020
@AlistairGempf AlistairGempf added a11y Accessibility-related task ws-home Tasks for the WS Home Team labels Jan 20, 2020
@AlistairGempf AlistairGempf removed the a11y Accessibility-related task label Jan 22, 2020
@j-pendlebury j-pendlebury self-assigned this Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants