Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update PR welcome links in readme #173

Merged
merged 5 commits into from
Dec 11, 2018
Merged

Update PR welcome links in readme #173

merged 5 commits into from
Dec 11, 2018

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Dec 10, 2018

Resolves #170

Updates PR's welcome link

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@dr3 dr3 added the alpha-2 label Dec 10, 2018
@dr3 dr3 self-assigned this Dec 10, 2018
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great. Unfortunately, since you created this, psammead-paragraph & psammead-visually-hidden-text have been updated, so you'll need to bump the relevant package.json, package-lock.json & changelog files.

@bcmn
Copy link
Contributor

bcmn commented Dec 11, 2018

Bear in mind this will sit oddly with #129. I don’t think there'll be any prompt to fix either branch.

Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dr3 dr3 merged commit d7ce22d into latest Dec 11, 2018
@dr3 dr3 deleted the PRWelcome branch December 11, 2018 14:50
@thekp thekp mentioned this pull request Jul 12, 2019
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants