Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Remove text knob from input-provider #1679

Merged
6 commits merged into from
Aug 9, 2019
Merged

Remove text knob from input-provider #1679

6 commits merged into from
Aug 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2019

Resolves #1598

Overall change: Remove text knob from input-provider

Code changes:

  • Remove text knob from input-provider

See #1598 (comment) and #1598 (comment). Suggestions on alternative ways to solve this are highly welcomed.


  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ghost ghost added ws-home Tasks for the WS Home Team ws-articles Tasks for the WS Articles Team simorgh-core-stream shared-components ws-media The World Service media stream labels Aug 8, 2019
@ghost ghost self-assigned this Aug 8, 2019
@ghost ghost marked this pull request as ready for review August 8, 2019 08:30
@ghost ghost requested review from dr3, j-pendlebury, pjlee11 and sareh as code owners August 8, 2019 08:30
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as everyone is happy about losing this functionality.

Copy link
Contributor

@andrew-nowak andrew-nowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweak to the comments, but otherwise lgtm

Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs conflicts to be resolved

@ghost ghost merged commit 2cb09d1 into latest Aug 9, 2019
@ghost ghost deleted the input-provider-bug branch August 9, 2019 06:38
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
shared-components simorgh-core-stream ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Provider with Storybook knobs not working
5 participants