This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ws-home
Tasks for the WS Home Team
ws-articles
Tasks for the WS Articles Team
simorgh-core-stream
shared-components
ws-media
The World Service media stream
labels
Aug 8, 2019
ghost
self-assigned this
Aug 8, 2019
ghost
marked this pull request as ready for review
August 8, 2019 08:30
ghost
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
August 8, 2019 08:30
DenisHdz
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as long as everyone is happy about losing this functionality.
andrew-nowak
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor tweak to the comments, but otherwise lgtm
packages/utilities/psammead-storybook-helpers/src/input-provider.jsx
Outdated
Show resolved
Hide resolved
packages/utilities/psammead-storybook-helpers/src/input-provider.jsx
Outdated
Show resolved
Hide resolved
…er.jsx Co-Authored-By: Andrew Nowak <[email protected]>
…er.jsx Co-Authored-By: Andrew Nowak <[email protected]>
Bopchy
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs conflicts to be resolved
dr3
approved these changes
Aug 8, 2019
ghost
deleted the
input-provider-bug
branch
August 9, 2019 06:38
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
shared-components
simorgh-core-stream
ws-articles
Tasks for the WS Articles Team
ws-home
Tasks for the WS Home Team
ws-media
The World Service media stream
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1598
Overall change: Remove text knob from
input-provider
Code changes:
text
knob frominput-provider
See #1598 (comment) and #1598 (comment). Suggestions on alternative ways to solve this are highly welcomed.