Merge pull request #1679 from bbc/input-provider-bug

Remove text knob from input-provider

packages/utilities/psammead-storybook-helpers/CHANGELOG.md

@@ -3,6 +3,7 @@
 <!-- prettier-ignore -->
 | Version | Description |
 |---------|-------------|
+| 4.0.0 | [PR#1679](https://github.com/bbc/psammead/pull/1679) Remove text knob from input-provider |
 | 3.3.4   | [PR#1685](https://github.com/bbc/psammead/pull/1685) Bump dependencies |
 | 3.3.3 | [PR#1682](https://github.com/bbc/psammead/pull/1682) Move all dev dependencies to top level package.json |
 | 3.3.2 | [PR#1595](https://github.com/bbc/psammead/pull/1595) Bump `@bbc/gel-foundations` |

packages/utilities/psammead-storybook-helpers/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bbc/psammead-storybook-helpers",
-  "version": "3.3.4",
+  "version": "4.0.0",
   "main": "dist/index.js",
   "module": "esm/index.js",
   "sideEffects": false,

packages/utilities/psammead-storybook-helpers/src/index.test.jsx

@@ -134,7 +134,6 @@ describe('Psammead storybook helpers', () => {
         });
 
         expect(select).toHaveBeenCalledTimes(1);
-        expect(text).toHaveBeenCalledTimes(1);
       });
 
       it('for multiple slots', () => {
@@ -159,7 +158,6 @@ describe('Psammead storybook helpers', () => {
         });
 
         expect(select).toHaveBeenCalledTimes(1);
-        expect(text).toHaveBeenCalledTimes(2);
       });
     });
 
@@ -179,7 +177,6 @@ describe('Psammead storybook helpers', () => {
       });
 
       expect(select).toHaveBeenCalledTimes(1);
-      expect(text).toHaveBeenCalledTimes(1);
     });
 
     it('defaults to service text for non-news services', () => {

packages/utilities/psammead-storybook-helpers/src/input-provider.jsx

@@ -1,5 +1,5 @@
 import React, { Fragment } from 'react';
-import { text, select } from '@storybook/addon-knobs';
+import { select } from '@storybook/addon-knobs';
 import { Helmet } from 'react-helmet';
 import * as scripts from '@bbc/gel-foundations/scripts';
 import LANGUAGE_VARIANTS from './text-variants';
@@ -16,18 +16,15 @@ const inputProvider = (slots, componentFunction, services) => () => {
   const service = LANGUAGE_VARIANTS[serviceName];
   const isNews = serviceName === 'news';
 
-  const slotTexts = (slots || []).map(({ name, defaultText }) =>
-    text(
-      `Content for ${name}`,
-      // Expect defaultText to be in English. When it is provided and we're
-      // displaying English language on the story, set the default text for
-      // this knob to defaultText.
-      // When we switch to a language other than English, set the default
-      // text for the knob to the snippet from LANGUAGE_VARIANTS for that
-      // language.
-      defaultText && isNews ? defaultText : service.text,
-    ),
-  );
+  const slotTexts = (slots || []).map(({ defaultText }) => {
+    // Expect defaultText to be in English. When it is provided and we're
+    // displaying English language on the story, set the default text for
+    // this knob to defaultText.
+    // When we switch to a language other than English, set the
+    // text for the slot to the snippet from LANGUAGE_VARIANTS for that
+    // language.
+    return defaultText && isNews ? defaultText : service.text;
+  });
 
   const script = scripts[service.script];
   const dir = service.dir || 'ltr';