Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Pull in media icons from psammead-assets #2159

Closed
1 task done
OlgaLyubin opened this issue Sep 17, 2019 · 3 comments · Fixed by #2199
Closed
1 task done

Pull in media icons from psammead-assets #2159

OlgaLyubin opened this issue Sep 17, 2019 · 3 comments · Fixed by #2199
Assignees
@OlgaLyubin
Labels
shared-components ws-home Tasks for the WS Home Team

Comments

@OlgaLyubin
Copy link
Contributor

OlgaLyubin commented Sep 17, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
This is a continuation for #1834 . Now that the PR that puts icons in psammead-assets is published, the icons need to be pulled into psammead-media-indicator.

Describe the solution you'd like
Remove media icons from psammead-media-indicator
Pull in media icons from psammead-assets into psammead-media-indicator

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@OlgaLyubin OlgaLyubin added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team shared-components labels Sep 17, 2019
@OlgaLyubin OlgaLyubin self-assigned this Sep 17, 2019
@OlgaLyubin
Copy link
Contributor Author

This is blocked until #2115 gets merged.

@Bopchy Bopchy removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 18, 2019
@Bopchy
Copy link
Contributor

Bopchy commented Sep 18, 2019

This can be done in one PR with #2158

@OlgaLyubin OlgaLyubin removed their assignment Sep 18, 2019
@OlgaLyubin OlgaLyubin removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Sep 18, 2019
@OlgaLyubin
Copy link
Contributor Author

This is unblocked now since #2115 got merged.

@OlgaLyubin OlgaLyubin self-assigned this Sep 19, 2019
@OlgaLyubin OlgaLyubin mentioned this issue Sep 20, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@OlgaLyubin OlgaLyubin

Labels
shared-components ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pull in media icons from psammead-assets BBC-archive/psammead
2 participants
@Bopchy @OlgaLyubin