Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add stories in storybook for media icons in psammead-assets #2158

Closed
1 task
OlgaLyubin opened this issue Sep 17, 2019 · 2 comments · Fixed by #2189
Closed
1 task

Add stories in storybook for media icons in psammead-assets #2158

OlgaLyubin opened this issue Sep 17, 2019 · 2 comments · Fixed by #2189
Assignees
@EinsteinNjoroge
Labels
shared-components ws-home Tasks for the WS Home Team

Comments

@OlgaLyubin
Copy link
Contributor

OlgaLyubin commented Sep 17, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Media Icons are now located in psammead-assets instead of psammead-media-indicator (see #1834 for more details). They require a storybook update.

Describe the solution you'd like
Add stories in psammead storybook for media icons SVGs in psammead-assets (isolated story for each icon).

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@OlgaLyubin OlgaLyubin transferred this issue from bbc/simorgh Sep 17, 2019
@OlgaLyubin OlgaLyubin added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. shared-components ws-home Tasks for the WS Home Team labels Sep 17, 2019
@OlgaLyubin
Copy link
Contributor Author

This is blocked until #2115 gets merged.

@Bopchy Bopchy mentioned this issue Sep 18, 2019
Closed
1 task
@Bopchy Bopchy removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 18, 2019
@OlgaLyubin OlgaLyubin removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Sep 18, 2019
@OlgaLyubin
Copy link
Contributor Author

This is unblocked now since #2115 got merged.

@EinsteinNjoroge EinsteinNjoroge self-assigned this Sep 19, 2019
@EinsteinNjoroge EinsteinNjoroge mentioned this issue Sep 19, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EinsteinNjoroge EinsteinNjoroge

Labels
shared-components ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add stories in storybook for media icons in psammead-assets BBC-archive/psammead
3 participants
@Bopchy @OlgaLyubin @EinsteinNjoroge