Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Move Media Icons from psammead-media-indicator/mediaIcons into psammead-assets #1834

Closed
1 task
sareh opened this issue Aug 20, 2019 · 1 comment · Fixed by #2115
Closed
1 task

Move Media Icons from psammead-media-indicator/mediaIcons into psammead-assets #1834

sareh opened this issue Aug 20, 2019 · 1 comment · Fixed by #2115
Assignees
@OlgaLyubin
Labels
shared-components ws-home Tasks for the WS Home Team ws-media The World Service media stream

Comments

@sareh
Copy link
Contributor

sareh commented Aug 20, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently we have the media icon SVGs in psammead-media-indicator https://github.com/bbc/psammead/blob/latest/packages/components/psammead-media-indicator/src/mediaIcons.jsx#L7

We should move the SVGs into psammead-assets so they can be used by other components.

Describe the solution you'd like

  • Add Media SVGs to psammead-assets & publish
  • Pull in Media SVGs into psammead-media-indicator

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: This should have unit tests (snapshots) for the svgs.

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@sareh sareh added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team shared-components labels Aug 20, 2019
@sareh sareh added the ws-media The World Service media stream label Aug 20, 2019
@sareh
Copy link
Contributor Author

sareh commented Aug 20, 2019

Just adding the other stream labels for visibility. Work should be carried out by the shared-components pod.

@aeroplanejane aeroplanejane removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Aug 27, 2019
@OlgaLyubin OlgaLyubin self-assigned this Sep 11, 2019
This was referenced Sep 12, 2019
Merged
Closed
Closed
@OlgaLyubin OlgaLyubin mentioned this issue Sep 20, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@OlgaLyubin OlgaLyubin

Labels
shared-components ws-home Tasks for the WS Home Team ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Media Icons from psammead-media-indicator into psammead-assets BBC-archive/psammead
3 participants
@sareh @OlgaLyubin @aeroplanejane