Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore WithTenantId for B2C, Refactor AADAuthority Tenant Checks #3517

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Jul 24, 2022

Fixes #3471

  • Ignore WithTenantId on B2C Authority
  • Refactor AAD Tenant "Type" detections

Testing
Unit Test added testing successful Build of PCA WithTenantId

@MichelZ MichelZ enabled auto-merge (squash) July 25, 2022 07:17
@pmaytak pmaytak self-requested a review July 27, 2022 18:01
Copy link
Contributor

@neha-bhargava neha-bhargava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MichelZ MichelZ merged commit 89bd932 into main Aug 1, 2022
@MichelZ MichelZ deleted the mize/resolve_authority_b2c branch August 1, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ResolveAuthority in AbstractApplicationBuilder doesn't take into account B2C authorities
3 participants