Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] ResolveAuthority in AbstractApplicationBuilder doesn't take into account B2C authorities #3471

Closed
pmaytak opened this issue Jul 12, 2022 · 1 comment · Fixed by #3517
Closed

[Bug] ResolveAuthority in AbstractApplicationBuilder doesn't take into account B2C authorities #3471

pmaytak opened this issue Jul 12, 2022 · 1 comment · Fixed by #3517
Labels
B2C bug P2
Milestone
4.46.0

Comments

@pmaytak
Copy link
Contributor

pmaytak commented Jul 12, 2022

Which version of MSAL.NET are you using?
Microsoft.Identity.Web 1.25.1 with MSAL.NET 4.42.0?

Actual behavior
See AzureAD/microsoft-identity-web#1805. MSAL throws AuthorityTenantSpecifiedTwice exception when domain and tenant ID are specified. ResolveAuthority doesn't take into account B2C authorities.

Expected behavior
Maybe disregard tenant ID if authority is B2C or at least a better error message.

Possible solution
Maybe refactor ResolveAuthority with a B2CAuthority check. Or make the error message clearer.
@pmaytak pmaytak mentioned this issue Jul 12, 2022
Closed
@MichelZ MichelZ mentioned this issue Jul 24, 2022
Merged
@pmaytak pmaytak moved this from Triage to In Progress in MSAL Customer Trust / QM Jul 26, 2022
@pmaytak pmaytak moved this from In Progress to Waiting for Code Review in MSAL Customer Trust / QM Jul 26, 2022
@pmaytak pmaytak added this to the 4.46.0 milestone Jul 26, 2022
Repository owner moved this from Waiting for Code Review to Fixed in MSAL Customer Trust / QM Aug 1, 2022
@pmaytak
Copy link
Contributor Author

pmaytak commented Aug 4, 2022

Released in 4.46.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B2C bug P2
Projects
MSAL Customer Trust / QM
Archived in project
Milestone
4.46.0
1 participant
@pmaytak