Upgrade to net6.0 on Windows

[kyle-rader]

Problem

net5.0 has now passed end of life. Our Mac and Linux builds are already on net6.0 but the Windows build has remained on net5.0-windows10.xxx to maintain current WAM support.

Problem 2

MSAL.NET has not yet added a net6-windows target and it will check this target at runtime and fail if you aren't using that version.

Workaround

We can target a new windows specific TFM (Target Framework Moniker) to build our Windows version of AzureAuth with net6 but manually use use the net5.0-windows10.xxx version of the MSAL.NET dll (Microsoft.Identity.Client.dll).

This works by updating our PackageReference to generate the special PkgPACKAGE_NAME varaibles (which we use heavily in Office) and then create a separate reference tag for MSAL where we point explicitly to the DLL in the package we want to use for that namespace.

Trimming and Testing

To help fully test I added publish scripts for both mac and windows (these work on both arm and intel macs + windows).

This is helpful because they build in release mode, publish, and trim - just like our CI. So the output in ./dist is the actual binary, (unsigned) we would be shipping. This helped uncover new trimming errors, and lead to adding 2 AssemblyRoots to ensure those Dlls are not trimmed away. This is only needed for the Windows build.

Testing

• Windows: Build and Test
  • Clear & Auth
    • IWA
    • Broker
    • Web
  • Auth silently with AT refresh (Web mode)
  • Both on and Off VPN (IWA fails off VPN as expected)
• Mac: Build and Test (Both ARM arm64 and Intel `x86_64)
  • Tests
  • refresh auth with web mode silently
  • clear
  • auth in web mode
  • auth in device code mode

[goagain]

Seems like changing csproj file doesn't trigger dotnet tests. Should we add it?

[kyle-rader]

IWA and Broker still work, but Web mode is now broken. @bgavrilMS is there a way to explicitly do system web browser and not embedded web browser?

EDIT: This is due to Assembly trimming. I'll have to add some trimming hints.

[kyle-rader]

Seems like changing csproj file doesn't trigger dotnet tests. Should we add it?

@goagain we do already have src/** in the trigger paths, it may not have run since I am in Draft mode?

[pmaytak]

IWA and Broker still work, but Web mode is now broken. @bgavrilMS is there a way to explicitly do system web browser and not embedded web browser?

EDIT: This is due to Assembly trimming. I'll have to add some trimming hints.

@kyle-rader To use OS browser add WithUseEmbeddedWebView(false) to AcquireTokenInteractive call.

More info here and here.

[goagain]

Tested all modes on Windows and Mac.

[Haard30]

Tested all modes on Windows