Use System Web Browser for Web mode to avoid cache poisoning #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-rader
force-pushed
the
system-web
branch
2 times, most recently
from
081f2c5 to
4557276
Compare
kyle-rader
force-pushed
the
system-web
branch
from
4557276 to
3506288
Compare
reillysiemens
approved these changes
Oct 24, 2022
Discussed offline, unlikely that this is a priority for MSAL.NET as WAM is the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the build system using AzureAuth directly the last source of cache poisoning is using web mode when pre-warming ado auth for Nuget. We can avoid cache poisoning by going back to system web browser when web auth is needed. Falling back to web should rarely happen now that IWA and broker are both used before web. By using system web browser instead of embedded web view - we won't risk cache poisoning since the system web browser should always be able to pass the device management CA policy properly.
This does mean that the prompt hint will not show if being prompted with the web browser. Which is tragic. But we also expect to see it far less.