Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@@customeAzureResource decorator for resources that doesn't use the base resource types #1923

Merged
merged 10 commits into from
Dec 5, 2024
Merged

@@customeAzureResource decorator for resources that doesn't use the base resource types #1923

merged 10 commits into from
Dec 5, 2024

Conversation

AlitzelMendez
Copy link
Member

issue: #1474

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 28, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
  • ✅ @azure-tools/typespec-azure-rulesets
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

Add the @Azure.ResourceManager.Legacy.customAzureResource decorator to identify ARM resources that do not use the base resource types.

@azure-tools/typespec-azure-rulesets - feature ✏️

Discourage usage of new decorator @Azure.ResourceManager.Legacy.customAzureResource

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@AlitzelMendez AlitzelMendez changed the title [WIP] @@customeAzureResource decorator for resources that doesn't use the base resource types @@customeAzureResource decorator for resources that doesn't use the base resource types Dec 2, 2024
@AlitzelMendez AlitzelMendez marked this pull request as ready for review December 2, 2024 19:13
@AlitzelMendez AlitzelMendez linked an issue Dec 2, 2024 that may be closed by this pull request
Can x-ms-azure-resource be safely removed #1474
Closed
@markcowl markcowl self-assigned this Dec 5, 2024
@AlitzelMendez AlitzelMendez added this pull request to the merge queue Dec 5, 2024
Merged via the queue into Azure:main with commit b29dfc6 Dec 5, 2024
23 checks passed
@AlitzelMendez AlitzelMendez deleted the new-decorator-custom-azure-resource branch December 5, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees

@markcowl markcowl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can x-ms-azure-resource be safely removed
3 participants
@AlitzelMendez @azure-sdk @markcowl