Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can x-ms-azure-resource be safely removed #1474

Closed
Tracked by #1850
timotheeguerin opened this issue Sep 4, 2024 · 4 comments · Fixed by #1923
Closed
Tracked by #1850

Can x-ms-azure-resource be safely removed #1474

timotheeguerin opened this issue Sep 4, 2024 · 4 comments · Fixed by #1923
Assignees
Labels
design:accepted Proposal for design has been discussed and accepted. lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented Sep 4, 2024

There is some spec still using it and seems like csharp autorest generator might make use of it.

  1. Figure out if this is actually useful
  2. If it is, why are spec using it not using the base resource types
  3. If they have valid legacy reason then we need some deprecated decorator to get parity
@markcowl markcowl self-assigned this Sep 6, 2024
@markcowl markcowl added design:needed A design request has been raised that needs a proposal lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library labels Sep 10, 2024
@markcowl markcowl added this to the [2024] October milestone Sep 10, 2024
@markcowl
Copy link
Member

markcowl commented Oct 22, 2024

  • This is still used by older emitters for c-sharp
  • We need an ARM decorator that will be consumed by autorest to add this extension
  • The decorator should be called @customAzureResource and have an associated linting rule that discourages its usage (this can be excluded from legacy rulesets)
  • We should relax the constraints on resource templates to accept such resources - this will likely require a new constraint decorator to check that something is a resource.

@markcowl markcowl added design:accepted Proposal for design has been discussed and accepted. and removed design:needed A design request has been raised that needs a proposal labels Nov 13, 2024
@markcowl markcowl removed their assignment Nov 13, 2024
@live1206
Copy link
Member

This is still used by older emitters for c-sharp

@markcowl Could you specify where the usage is in older emitter of csharp? I couldn't find the usage in https://github.com/Azure/autorest.csharp

@markcowl
Copy link
Member

There are actually multiple places where this or a similar mechanism (configuring paths as resource paths) are used in c-sharp

@pshao25
Copy link
Member

pshao25 commented Nov 14, 2024

We only found ComminutyGallery fits this situation. Do you have more examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design:accepted Proposal for design has been discussed and accepted. lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Projects
None yet
5 participants