Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add armResourceType scalar in typespec-azure-core #1272

Merged
merged 18 commits into from
Dec 6, 2024
Merged

add armResourceType scalar in typespec-azure-core #1272

merged 18 commits into from
Dec 6, 2024

Conversation

ArcturusZhang
Copy link
Member

Fixes #1268

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 31, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-core
  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-core - feature ✏️

Add armResourceType scalar, and changed some properties to be armResourceType instead of string

@azure-tools/typespec-azure-resource-manager - feature ✏️

Add armResourceType scalar, and changed some properties to be armResourceType instead of string

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@tadelesh
Copy link
Member

@allenjzhang could you help to review?

timotheeguerin
timotheeguerin previously requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should go through some design discussion to approve this new type

@ArcturusZhang
Copy link
Member Author

We should go through some design discussion to approve this new type

Yeah I assume we should go through design discussions before we could merge this. What is the process of that?

@timotheeguerin
Copy link
Member

We can talk about it tomorrow in dpg meeting(or later one if we can't) don't think this needs to be brought up to the Wednesday one

@ArcturusZhang
Copy link
Member Author

@timotheeguerin any update on this?

@ArcturusZhang ArcturusZhang changed the title add resource type scalar in typespec-azure-core add armResourceType scalar in typespec-azure-core Nov 13, 2024
markcowl
markcowl reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlitzelMendez Any comments on the common-types/gen.ts ?

packages/samples/common-types/gen.ts Show resolved Hide resolved
@markcowl markcowl added the needs-info Mark an issue that needs reply from the author or it will be closed automatically label Nov 26, 2024
@markcowl markcowl enabled auto-merge December 6, 2024 00:23
@markcowl markcowl added this pull request to the merge queue Dec 6, 2024
Merged via the queue into Azure:main with commit 1139adf Dec 6, 2024
21 of 23 checks passed
@ArcturusZhang ArcturusZhang deleted the add-resource-type branch December 6, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlitzelMendez AlitzelMendez AlitzelMendez left review comments

@timotheeguerin timotheeguerin timotheeguerin left review comments

@markcowl markcowl markcowl approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees

@markcowl markcowl

@AlitzelMendez AlitzelMendez

Labels
needs-info Mark an issue that needs reply from the author or it will be closed automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resourceType scalar in typespec-azure-core library
6 participants
@ArcturusZhang @azure-sdk @tadelesh @timotheeguerin @markcowl @AlitzelMendez