Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resourceType scalar in typespec-azure-core library #1268

Closed
ArcturusZhang opened this issue Jul 31, 2024 · 2 comments · Fixed by #1272
Closed

Add resourceType scalar in typespec-azure-core library #1268

ArcturusZhang opened this issue Jul 31, 2024 · 2 comments · Fixed by #1272
Labels
design:needed A design request has been raised that needs a proposal lib:azure-core Issues for @azure-tools/typespec-azure-core library triaged:core
Milestone
Backlog

Comments

@ArcturusZhang
Copy link
Member

We also need a resourceType scalar to make a specific scalar to be the arm resource type.
DotNet SDK will generate resourceType into Azure.Core.ResourceType.
Other languages could simply generate it as string.

The definition could be

scalar resourceType extends string;

And the TrackedResource, ProxyResource template needs to be updated accordingly - their type property should be resourceType.
@ArcturusZhang ArcturusZhang added lib:azure-core Issues for @azure-tools/typespec-azure-core library lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library emitter:autorest Issues for @azure-tools/typespec-autorest emitter feature New feature or request labels Jul 31, 2024
@ArcturusZhang ArcturusZhang mentioned this issue Jul 31, 2024
Merged
@timotheeguerin timotheeguerin added the design:needed A design request has been raised that needs a proposal label Jul 31, 2024
@markcowl
Copy link
Member

Also, this should change the type of the allowedResourceTypes array in the armResourceIdentifier template

@markcowl markcowl removed design:needed A design request has been raised that needs a proposal lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library emitter:autorest Issues for @azure-tools/typespec-autorest emitter labels Aug 12, 2024
@markcowl
Copy link
Member

est: 5

@markcowl markcowl added this to the [2024] September milestone Aug 12, 2024
@markcowl markcowl modified the milestones: [2024] October, Backlog Oct 9, 2024
@markcowl markcowl added design:needed A design request has been raised that needs a proposal and removed feature New feature or request labels Oct 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 6, 2024
@ArcturusZhang @timotheeguerin @markcowl
add armResourceType scalar in typespec-azure-core (#1272)
1139adf 
Fixes #1268

---------

Co-authored-by: Timothee Guerin <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design:needed A design request has been raised that needs a proposal lib:azure-core Issues for @azure-tools/typespec-azure-core library triaged:core
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

add armResourceType scalar in typespec-azure-core ArcturusZhang/typespec-azure
3 participants
@timotheeguerin @markcowl @ArcturusZhang