Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCGC][Bug] model is array case not handled correctly #690

Closed
haolingdong-msft opened this issue Apr 18, 2024 · 0 comments · Fixed by #692
Closed

[TCGC][Bug] model is array case not handled correctly #690

haolingdong-msft opened this issue Apr 18, 2024 · 0 comments · Fixed by #692
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library needs-area

Comments

@haolingdong-msft
Copy link
Member

TSP definition:

model ResourceArray is Resource[];

 @route("/get-array")
 getArray(): ResourceArray;

TCGC will return the type for ResourceArray as a SDKModelType with additional properties, which is not correct. It should return it as SdkArrayType.
image
@haolingdong-msft haolingdong-msft mentioned this issue Apr 18, 2024
Closed
@tadelesh tadelesh mentioned this issue Apr 18, 2024
Merged
@markcowl markcowl added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Apr 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 19, 2024
@tadelesh
fix wrong judgement for array type (#692)
62a9231 
@iscai-msft please help to review and release, thanks.

fix: #690

cc: @haolingdong-msft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library needs-area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix wrong judgement for array type Azure/typespec-azure
2 participants
@markcowl @haolingdong-msft