-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpg, integrate TCGC getAllModels - basic support #2564
Comments
The Model is get from the raw Type. Use raw in it is meaningless. |
Please try to use the real models returned by TCGC instead of raw. And we shall continue reducing the usage of 'raw' in the source code till it is no longer needed. cc @lmazuel |
I was saying the same thing... "Use raw in it is meaningless." |
|
Personally opinion: |
I agree, I will try to make the change incrementally and split to seperate mergable pr. |
TCGC will deprecate |
TCGC
getAllModels()
code is already on main. We will need togetAllModels()
in emitter to replace the logics inprocessModels()
.Tasks
SdkNullableType
#2730Possible gaps between TCGC type and compiler type:
unkown
type in compiler will be converted toany
type in TCGCSdkType
.void
andnever
is not supported in TCGCSdkType
yet. TCGC issue: Enhance typing for intrinsic type typespec-azure#292SdkType
does not containnamespace
information. Model and enum type fromgetAllModels
does not have namespace typespec-azure#290SdkType.description
andSdkType.detail
: If both@summary
and@doc
exist, .description
will be the content in@summary
anddetail
will be the content in@doc
. If only@doc
exists, thendescription
will be the content in@doc
.@format
, it will map the type with@format
to anSdkBuiltInType
. (expected)@clientName
decorator typespec-azure#554UserAssignedIdentity
: [TCGC] [ARM] Expected client code on definitionmodel UserAssignedIdentities is Record<UserAssignedIdentity>;
typespec-azure#825Log Time cost: 10-12 weeks
TCGC dependencies
getAllModels
does not have namespace typespec-azure#290@clientName
decorator typespec-azure#554model UserAssignedIdentities is Record<UserAssignedIdentity>;
typespec-azure#825The text was updated successfully, but these errors were encountered: