-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsp, TCGC common layer, adopt model types #2698
tsp, TCGC common layer, adopt model types #2698
Conversation
# Conflicts: # typespec-extension/package-lock.json # typespec-extension/package.json # typespec-extension/src/code-model-builder.ts
# Conflicts: # typespec-extension/changelog.md # typespec-extension/package-lock.json # typespec-extension/package.json # typespec-tests/package.json # typespec-tests/src/main/java/com/cadl/armresourceprovider/models/ManagedIdentityType.java # typespec-tests/src/main/java/com/cadl/flatten/implementation/models/SendLongRequest.java # typespec-tests/src/main/java/com/cadl/flatten/implementation/models/UploadTodoRequest.java
Our build passes at version "@azure-tools/typespec-client-generator-core": "0.42.0", but encouter generation error at version "@azure-tools/typespec-client-generator-core": "0.42.1". Seems TCGC has issue on version Fixed the TCGC version to |
typespec-tests/src/main/java/com/cadl/armresourceprovider/models/ManagedServiceIdentity.java
Show resolved
Hide resolved
0.42.1 should be a wrong hotfix release. we are trying to release another 0.42.2. |
# Conflicts: # typespec-extension/src/code-model-builder.ts
Remaining issues on this PR:
Three pending discussion issues:
|
Offline synced with Haoling. The extra generated Though, tsp-arm themselves discourage use of @weidongxu-microsoft We probably need a special handling for Raised an issue here: Azure/typespec-azure#824 |
typespec-tests/src/main/java/com/type/union/IntsOnlyAsyncClient.java
Outdated
Show resolved
Hide resolved
# Conflicts: # typespec-extension/changelog.md # typespec-extension/package-lock.json # typespec-extension/package.json # typespec-tests/package.json # typespec-tests/tsp/union.tsp
# Conflicts: # typespec-extension/changelog.md # typespec-extension/package-lock.json # typespec-extension/package.json # typespec-extension/src/code-model-builder.ts # typespec-tests/package.json # typespec-tests/tsp/internal.tsp
e488578
to
8d45984
Compare
API view with diff comparing this PR's generated code for
typespec-tests
withmain
branch:https://apiview.dev/Assemblies/Review/e0cf256f814e456bac0f0d751bd4aa9f/d08e9493669445c4bf9916c090262bd5?diffRevisionId=b988ab5926314dc0a7d226750d035115&doc=False&diffOnly=True
Note this:
Currently TCGC treated
enum
as fixed enum, and this can cause breaking changes in mgmt plane sdk. typespec-azure will fix the tsp definition in 0.42.Fix #2564
Will create issues for below follow up items and create seperate PR to support:
A | B | null
: TSP, TCGC common layer, adoptSdkNullableType
#2730