Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows image build with buildx #334

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fix: windows image build with buildx #334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ endif
.PHONY: e2e-container
e2e-container: build build-windows
docker buildx rm container-builder || true
docker buildx create --use --name=container-builder
# only moby/buildkit:foreign-mediatype works on building Windows image now
# https://github.com/moby/buildkit/pull/1879
# Github issue: https://github.com/moby/buildkit/issues/1877
docker buildx create --use --name=container-builder --driver-opt image=moby/buildkit:v0.7.2
ifdef CI_KIND_CLUSTER
DOCKER_IMAGE=$(REGISTRY)/$(IMAGE_NAME) make image
kind load docker-image --name kind $(REGISTRY)/$(IMAGE_NAME):$(IMAGE_VERSION)
Expand Down