Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows image build with buildx #334

Merged
merged 1 commit into from
Dec 10, 2020
Merged

fix: windows image build with buildx #334

merged 1 commit into from
Dec 10, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Dec 9, 2020 •
edited
Loading

Reason for Change:

This is a workaround until the bug is fixed in buildkit: moby/buildkit#1879

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

Special Notes for Reviewers:

@aramase
Copy link
Member Author

aramase commented Dec 9, 2020

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase force-pushed the buildx branch 2 times, most recently from 744e37a to f2e3c35 Compare December 9, 2020 06:27
@aramase
Copy link
Member Author

aramase commented Dec 9, 2020

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase changed the title fix: debug pipeline buildx failure fix: windows image build with buildx Dec 9, 2020
@aramase aramase added this to the 0.0.11 milestone Dec 9, 2020
@aramase aramase marked this pull request as ready for review December 9, 2020 06:47
@aramase aramase requested a review from ritazh December 9, 2020 17:48
ritazh
ritazh approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aramase aramase merged commit 3fc7424 into Azure:master Dec 10, 2020
@aramase aramase deleted the buildx branch December 10, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@aramase @ritazh