iotedge check improvements
#926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructure list of checks per the new spec. - Allow the user to override the expected latest version of iotedged. If this is set, the command does not reach out to the aka.ms URL to fetch the expected latest version. - Allow the user to override the name of the diagnostics image. - Differentiate between checks with warnings and checks that were skipped because a previous check failed. - Hide skipped tests unless `--verbose` is set. - Add check that device will not run in quick start mode. - Downgrade error that Moby is not being used in Windows to a warning. - Fix check that the edge agent can reach the management URI to handle the case where the listening URI is an fd. - Downgrade error that iotedged is not the latest version to a warning. - Fix host local time check to handle the case where the host is too far behind the SNTP server. - Fix host local time check to report a warning instead of an error if the SNTP server is not reachable. - Remove checks for the versions of edge agent and edge hub, since these should be reported by the portal, etc. - Remove the check that the Azure IoT Hub AMQP and MQTT ports can be reached from the host. Instead check these from within a module container. - Add check that any ports that edge hub wants to bind to on the host are available. - Use colors when writing the success / warning / error results of the checks. - Add note to default config.yaml about how the connect URIs must match the file paths in the systemd socket files.
This comment has been minimized.
This comment has been minimized.
Some customers are known to have middleboxes that allow TCP connections on these ports but block TLS traffic.
myagley
requested changes
Mar 11, 2019
edgelet/iotedge/src/check.rs
Outdated
| }), | ||
| ("edge hub can bind to ports on host", edge_hub_ports_on_host), | ||
| ( | ||
| "container runtime network allows name resolution", |
There was a problem hiding this comment.
Venkat suggests "modules on the container runtime network can resolve each other by name".
There was a problem hiding this comment.
Oh wait. I thought this was related to the port binding check. You can disregard my comment.
myagley
previously approved these changes
Mar 11, 2019
arsing
force-pushed
the
iotedge-diagnose
branch
from
c730d54 to
db07949
Compare
myagley
approved these changes
Mar 12, 2019
arsing
added a commit
that referenced
this pull request
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure list of checks per the new spec.
Allow the user to override the expected latest version of iotedged.
If this is set, the command does not reach out to the aka.ms URL to
fetch the expected latest version.
Allow the user to override the name of the diagnostics image.
Differentiate between checks with warnings and checks that were skipped
because a previous check failed.
Hide skipped tests unless
--verboseis set.Add check that device will not run in quick start mode.
Downgrade error that Moby is not being used in Windows to a warning.
Fix check that the edge agent can reach the management URI to handle
the case where the listening URI is an fd.
Downgrade error that iotedged is not the latest version to a warning.
Fix host local time check to handle the case where the host is too
far behind the SNTP server.
Fix host local time check to report a warning instead of an error if
the SNTP server is not reachable.
Remove checks for the versions of edge agent and edge hub, since
these should be reported by the portal, etc.
Remove the check that the Azure IoT Hub AMQP and MQTT ports can be reached
from the host. Instead check these from within a module container.
Add check that any ports that edge hub wants to bind to on the host are
available.
Use colors when writing the success / warning / error results of
the checks.
Add note to default config.yaml about how the connect URIs must match
the file paths in the systemd socket files.