iotedge check improvements part 2
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update user-friendly error messages according to new spec. - Only display error causes when `--verbose` is set. - Also check expiry of quickstart device CA cert. - Print message reminding user to run as root if "Edge hHb can bind to ports" check fails with EPERM, since 443 is a privileged port. - Remove "container can resolve other container hostname" check, since it is not a reported issue.
…er engine config file couldn't be parsed at all.
…ualt network on Windows.
myagley
previously approved these changes
Apr 1, 2019
edgelet/iotedge/src/check.rs
Outdated
| dns: Option<Vec<String>>, | ||
| } | ||
|
|
||
| let daemon_config_file = File::open(CONTAINER_ENGINE_CONFIG_PATH) |
There was a problem hiding this comment.
Should we make this configurable?
myagley
approved these changes
Apr 1, 2019
|
🎉👏 |
arsing
added a commit
that referenced
this pull request
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update user-friendly error messages according to new spec.
Only display error causes when
--verboseis set.Add causes to warning messages, and only display then when
--verboseis set.
Also check expiry of quickstart device CA cert.
Print message reminding user to run as root if "Edge Hub can bind to ports"
check fails with EPERM, since 443 is a privileged port.
Remove "container can resolve other container hostname" check, since it is
not a reported issue.
Remove "container on default network can resolve IoT Hub" checks
on Windows since the "module runtime network" checks already cover it.
Tweak colors on Windows to match default PowerShell colors.
Strip
iotedge-diagnosticsbinary to reduce container image size.TODO:
Get new aka.ms URLs from Venkat (marked<TODO: aka.ms URL>).