Use HTTPS proxy in Edge Hub #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myagley
requested changes
Jan 9, 2019
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.CloudProxy/DeviceScopeApiClient.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: damonbarry <[email protected]>
varunpuranik
reviewed
Jan 9, 2019
| Assert.True(((AmqpTransportSettings)expectedTransportSettings).Equals((AmqpTransportSettings)transportSettings)); | ||
| case AmqpTransportSettings _: | ||
| { | ||
| var expected = (AmqpTransportSettings)expectedTransportSettings; |
There was a problem hiding this comment.
Nit:
case AmqpTransportSettings expected:
case MqttTransportSettings expected:
varunpuranik
approved these changes
Jan 9, 2019
|
@myagley I made the requested changes |
myagley
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linux, .NET Core recognizes and honors the
https_proxyenvironment variable when it is present in a module like Edge Agent or Edge Hub. The behavior is different in Windows, however, where the default WinInet proxy settings are used (as set via the Control Panel, or Internet Explorer) andhttps_proxyis ignored. This is especially a problem in RS5 nanoserver containers, which don't even expose the WinInet proxy settings.The fix is to look for the environment variable ourselves, create a
WebProxyobject, and attach it to theITransportSettingsobject that we pass into the SDK'sModuleClient. We technically only have to do this for Windows, but we'll do it for all platforms, for consistency.This change updates Edge Hub. Edge Agent was updated previously (see #687). Note that for Edge Hub, we have to pass the proxy info into our own
System.Net.Http.HttpClient-basedDeviceScopeApiClientas well asModuleClient.