-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HTTPS proxy in Edge Agent #687
Merged
Merged
+216
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunpuranik
reviewed
Jan 7, 2019
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.IoTHub/ModuleClient.cs
Outdated
Show resolved
Hide resolved
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.IoTHub/ModuleClient.cs
Outdated
Show resolved
Hide resolved
varunpuranik
previously approved these changes
Jan 7, 2019
varunpuranik
approved these changes
Jan 8, 2019
damonbarry
added a commit
that referenced
this pull request
Jan 10, 2019
In Linux, .NET Core recognizes and honors the `https_proxy` environment variable when it is present in a module like Edge Agent or Edge Hub. The behavior is different in Windows, however, where the default WinInet proxy settings are used (as set via the Control Panel, or Internet Explorer) and `https_proxy` is ignored. This is especially a problem in RS5 nanoserver containers, which don't even expose the WinInet proxy settings. The fix is to look for the environment variable ourselves, create a `WebProxy` object, and attach it to the `ITransportSettings` object that we pass into the SDK's `ModuleClient`. We technically only have to do this for Windows, but we'll do it for all platforms, for consistency. This change updates Edge Hub. Edge Agent was updated previously (see #687). Note that for Edge Hub, we have to pass the proxy info into our own `System.Net.Http.HttpClient`-based `DeviceScopeApiClient` as well as `ModuleClient`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linux, .NET Core recognizes and honors the
https_proxy
environment variable when it is present in a module like Edge Agent or Edge Hub. The behavior is different in Windows, however, where the default WinInet proxy settings are used (as set via the Control Panel, or Internet Explorer) andhttps_proxy
is ignored. This is especially a problem in RS5 nanoserver containers, which don't even expose the WinInet proxy settings.The fix is to look for the environment variable ourselves, create a
WebProxy
object, and attach it to theITransportSettings
object that we pass into the SDK'sModuleClient
. We technically only have to do this for Windows, but we'll do it for all platforms, for consistency.This PR includes the change for Edge Agent. Edge Hub will come next.
I've tested this on Windows. I still need to test on Linux...I've tested on Windows and Linux in a proxy (squid) environment.