Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests ARM, test case for listing available operations #713

Closed
wants to merge 13 commits into from

Conversation

v-hongli1
Copy link
Member

@v-hongli1 v-hongli1 commented Aug 27, 2024

Cadl Ranch Contribution Checklist:

  • I have written a scenario spec
  • I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
  • I have written a mock API
  • I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 28, 2024
v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 28, 2024
v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 28, 2024
v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 28, 2024
v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 28, 2024
v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 29, 2024
v-hongli1 added a commit to v-hongli1/cadl-ranch that referenced this pull request Aug 29, 2024
archerzz and others added 5 commits August 29, 2024 13:31
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-hongli1 v-hongli1 requested a review from iscai-msft August 30, 2024 04:14
@@ -907,6 +907,35 @@ Expected response body:
}
```

### Azure_ResourceManager_Models_Resources_ListAvailableOperations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this to list which resources are available? or are you looking for available operations on a resource? I'm confused by the name. What about Azure_ResourceManager_Resources_ListAvailable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for listing all available operations for an RP, not for a particular resource or resource type.

Reason for putting it under Resources, is that it's a common interface(API) for almost all RPs, and it only has one scenario, which is interface Operations extends Azure.ResourceManager.Operations {}. I'm not sure it's worth a separate folder/file.

@v-hongli1 v-hongli1 closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants