refactor(spec): add uint8 for int encoding and templatize #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .net doesn't support uint32 yet, so use uint8 - use a value which will be negative in signed int
archerzz
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
tadelesh and
timotheeguerin
as code owners
🦋 Changeset detectedLatest commit: 43c7331 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iscai-msft
reviewed
Aug 23, 2024
iscai-msft
reviewed
Aug 26, 2024
archerzz
changed the title
iscai-msft
approved these changes
Aug 27, 2024
weidongxu-microsoft
approved these changes
Aug 28, 2024
v-hongli1
pushed a commit
to v-hongli1/cadl-ranch
that referenced
this pull request
Aug 29, 2024
- .net generator doesn't support `uint32` yet, so add a `uint8` test case - templatize int encoding test cases --------- Co-authored-by: Mingzhe Huang (from Dev Box) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cadl Ranch Contribution Checklist:
@scenarionames. Someone can look at the list of scenarios and understand what I'm covering.@scenarioDocs for extra scenario description and to tell people how to pass my mock api check.