Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use-endpoint-instead-of-localhost #425

Merged
merged 3 commits into from
Sep 25, 2023
Merged

use-endpoint-instead-of-localhost #425

merged 3 commits into from
Sep 25, 2023

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Sep 22, 2023

Cadl Ranch Contribution Checklist:

  • I have written a scenario spec
  • I have meaningful @scenario names. Someone can look at the list of scenarios and understand what I'm covering.
  • I have written a mock API
  • I have used @scenarioDocs for extra scenario description and to tell people how to pass my mock api check.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 124c232

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@azure-tools/cadl-ranch-specs Patch
@azure-tools/cadl-ranch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qiaozha qiaozha requested a review from chunyu3 September 22, 2023 06:34
weidongxu-microsoft
weidongxu-microsoft approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure your local test is good.

packages/cadl-ranch-specs/http/resiliency/srv-driven/main.tsp Show resolved Hide resolved
@qiaozha qiaozha mentioned this pull request Sep 22, 2023
Merged
@qiaozha
Copy link
Member Author

qiaozha commented Sep 22, 2023

make sure your local test is good.

Yeah, I have tested it in Azure/autorest.typescript#2032, it should work.

@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Sep 25, 2023
Merged
4 tasks
@weidongxu-microsoft weidongxu-microsoft merged commit f0ebe14 into Azure:main Sep 25, 2023
@qiaozha qiaozha deleted the use-endpoint-instead-of-localhost branch October 8, 2023 06:18
@archerzz archerzz mentioned this pull request Jun 13, 2024
Closed
archerzz pushed a commit to archerzz/cadl-ranch that referenced this pull request Jun 13, 2024
fix(decorator): replace hard code url with {endpoint} in `@scenario…
b1a7050 
…Service`

Hard coded value should be replaced by a parameter, like Azure#425

fix Azure#597
@archerzz archerzz mentioned this pull request Jun 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@chunyu3 chunyu3 chunyu3 approved these changes

@tadelesh tadelesh tadelesh approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@tjprescott tjprescott Awaiting requested review from tjprescott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiaozha @tadelesh @chunyu3 @weidongxu-microsoft