Skip to content
This repository has been archived by the owner on Jan 21, 2025. It is now read-only.

bug(decorator): hard coded server url in @scenarioService #597

Closed
Tracked by #3994
archerzz opened this issue Jun 13, 2024 · 0 comments · Fixed by #598
Closed
Tracked by #3994

bug(decorator): hard coded server url in @scenarioService #597

archerzz opened this issue Jun 13, 2024 · 0 comments · Fixed by #598
Assignees
@archerzz
Labels
bug Something isn't working

Comments

@archerzz
Copy link
Member

Problem

See the codes:

cadl-ranch/packages/cadl-ranch-expect/src/decorators.ts

Line 241 in 2fb006d

context.call($server, target, "http://localhost:3000", "TestServer endpoint");

@scenarioService will set @server("http://localhost:3000", "TestServer endpoint"). We should change the literal value to a parameter, like #425
@archerzz archerzz added the bug Something isn't working label Jun 13, 2024
@archerzz archerzz self-assigned this Jun 13, 2024
@archerzz archerzz mentioned this issue Jun 13, 2024
Closed
archerzz pushed a commit to archerzz/cadl-ranch that referenced this issue Jun 13, 2024
fix(decorator): replace hard code url with {endpoint} in `@scenario…
b1a7050 
…Service`

Hard coded value should be replaced by a parameter, like Azure#425

fix Azure#597
@archerzz archerzz mentioned this issue Jun 13, 2024
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@archerzz archerzz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(decorator): replace hard code url with {endpoint} in @scenarioService archerzz/cadl-ranch
1 participant
@archerzz