Vibhansa/truncate update #1517
Vibhansa/truncate update #1517
Conversation
* Preserve block on flush and delete them on close instead.
* Adding proxy from environment fix
* Enabling random write
* adding direct_io data validation test with block cache
* New data test pipeline added
* return error when download fails during overwriting a block
vibhansa-msft
requested review from
souravgupta-msft,
ashruti-msft and
syeleti-msft
as code owners
| } | ||
| return data, err | ||
|
|
||
| return bb.createSparseFile(name, newSize, blockSize, blkList, idLen) |
There was a problem hiding this comment.
If file size is not aligning with the block size and truncate is used to expand the size, this will lead to irregular blocksizes in the block list.
Eg: lets say blocksize = 4M
file size = 5M (i.e., 2blocks) block1 = 4M, block2 = 1M
Call for truncate(10M)
I suppose the logic in this PR will make the block list look like this after truncate operation:
block1 = 4M, block2 = 1M, block3 = 4M, block4 = 1M.
Although this looks correct but the subsequent operations in block cache cannot utilize this sort of blocklist.
Please correct me if I am wrong
| return blockList | ||
| } | ||
|
|
||
| func (bb *BlockBlob) TruncateFile(name string, size int64) error { | ||
| // log.Trace("BlockBlob::TruncateFile : name=%s, size=%d", name, size) |
There was a problem hiding this comment.
Can be removed the commented line
| data, err := bb.HandleSmallFile(name, size, attr.Size) | ||
| if blockSize == 0 { | ||
| // Nothing is configured then assume 16MB as default size | ||
| blockSize = 16 * 1024 * 1024 |
There was a problem hiding this comment.
Is this standard size? if not, we have to document it somewhere.
| _ = h.Close() | ||
| os.Remove(filename) | ||
|
|
||
| err = suite.az.TruncateFile(internal.TruncateFileOptions{Name: filename, Size: fs.TruncatedSize, BlockSize: 16 * MB}) |
There was a problem hiding this comment.
Should we also verify the block size for 1,2 use case after truncate.
| @@ -0,0 +1,55 @@ | |||
|
|
|||
There was a problem hiding this comment.
Is this file needed?
No description provided.