Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve blocks on flush #1487

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Preserve blocks on flush #1487

merged 7 commits into from
Aug 8, 2024

Conversation

vibhansa-msft
Copy link
Member

@vibhansa-msft vibhansa-msft commented Aug 2, 2024 •
edited
Loading

  • Do not delete blocks on sync/flush and preserve them for later usage.
  • Delete them only when file is closed.

@vibhansa-msft vibhansa-msft added this to the v2-2.3.2 milestone Aug 2, 2024
@vibhansa-msft vibhansa-msft changed the title Channel close fix Preserve blocks on flush Aug 3, 2024
@vibhansa-msft vibhansa-msft merged commit b47e5fa into feature/2.3.2 Aug 8, 2024
5 checks passed
@vibhansa-msft vibhansa-msft deleted the vibhansa/closechannelfix branch August 8, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souravgupta-msft souravgupta-msft souravgupta-msft approved these changes

@ashruti-msft ashruti-msft Awaiting requested review from ashruti-msft

@syeleti-msft syeleti-msft Awaiting requested review from syeleti-msft

Assignees
No one assigned
Labels
bug integrity ready-to-merge
Projects
None yet
Milestone
v2-2.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@vibhansa-msft @souravgupta-msft