Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
February release highlights for JavaScript & TypeScript #2333
February release highlights for JavaScript & TypeScript #2333
Changes from 9 commits
ba68932
17a69c3
b03ffda
ce3ac4b
7bf2231
944c23e
236ec58
65b1514
9e7409f
94526fa
803fd73
84e451d
3d5199b
360d389
43a87ff
7c80183
724e0cb
759fe94
e23b0b3
7c7f2f8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we talk about what the problem before was? If I am an Azure Stack user, I wouldnt know whether this line would apply to me or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A dependency update is not a release highlight unless it solved a major problem for the customer. I recall the user did have some trouble which required us to do this update. Mentioning that here would help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the original issue: Azure/azure-sdk-for-js#13531
That issue is still open and the real solution is not trivial. This update helps but it's very minor. I'll remove the highlight entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was it returning before? Does the user have to change their code? If this is not a breaking change or highly impacting, perhaps we can skip mentioning it?
The points under
Major Fixes on @azure/[email protected]
do not seem to be developer impacting changes either. They do not need to react to these changes. I would recommend removing both theMajor Fixes
and this current section here and have say just this lineSee What is a developer impacting change?
cc @maorleger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a breaking change, but from one beta to another, since this client hasn't been GAd.
BackupResult and RestoreResult from backup/restore long running operations now contain additional information about the operation, we can say that 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the changelog link at this level? Wouldnt the changelog link a few lines above suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally point to the exact version in the changelog above. In this case we have two, so I thought on separating them.