-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
February release highlights for JavaScript & TypeScript #2333
Conversation
February release notes for JavaScript and TypeScript. Please suggest changes with your release notes. If you're looking for inspiration: - [What's a Developer Impacting Change?](https://github.com/Azure/azure-sdk/blob/08f279b39a4c19822b1509e6b10fc3ce256607b5/docs/policies/releasenotes.md#whats-a-developer-impacting-change). - Highlight guidelines: <https://azure.github.io/azure-sdk/policies_releasenotes.html> - September's PR: #1750 - October's PR: #1878 - November's PR: #2029 - December's PR: #2138 - January's PR: #2240
@sadasant The phrasing of "changes on" sounds strange to me, and I think we should replace it with "in" in the section headers. ("changes on @azure/[email protected]" -> "changes in @azure/[email protected]"). I'll fill out my notes according to the template here, but this is just some extra feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving comments for the Event Hubs package.
@witemple-msft @chradek @ljian3377 Thank you! I have pushed an update here: ce3ac4b Please review again! |
The updates for synapse are very small. I coordinated this with Jonathan!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see Search here...
Can we do a check on whether our partners have released anything?
- Monitor
- Communications
- Digital twins
- Synapse
- Quantum
- Attestation
|
||
#### @azure/storage-blob [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/CHANGELOG.md) | ||
|
||
##### Major Fixes in @azure/[email protected] ([Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/CHANGELOG.md#1241-2021-02-03)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the changelog link at this level? Wouldnt the changelog link a few lines above suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally point to the exact version in the changelog above. In this case we have two, so I thought on separating them.
releases/2021-02/js.md
Outdated
##### Major Fixes in @azure/[email protected] ([Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/CHANGELOG.md#123-2021-02-09)) | ||
|
||
- Fixed Azure Stack support for the NodeJS version of the `InteractiveBrowserCredential`. | ||
- The 'keytar' dependency has been updated to the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A dependency update is not a release highlight unless it solved a major problem for the customer. I recall the user did have some trouble which required us to do this update. Mentioning that here would help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the original issue: Azure/azure-sdk-for-js#13531
That issue is still open and the real solution is not trivial. This update helps but it's very minor. I'll remove the highlight entry.
releases/2021-02/js.md
Outdated
|
||
##### Major Fixes in @azure/[email protected] ([Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/CHANGELOG.md#123-2021-02-09)) | ||
|
||
- Fixed Azure Stack support for the NodeJS version of the `InteractiveBrowserCredential`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we talk about what the problem before was? If I am an Azure Stack user, I wouldnt know whether this line would apply to me or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on this?
Fixed a bug that appeared while using
InteractiveBrowserCredential
to authenticate against Azure Stack from NodeJS (for local apps that would ask for authentication using a browser window). Azure Stack has specific authentication requirements that were missed on our previousInteractiveBrowserCredential
release.
|
||
##### Changes on @azure/[email protected] | ||
|
||
- Backup and restore operations will now return a `BackupResult` and `RestoreResult` as appropriate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was it returning before? Does the user have to change their code? If this is not a breaking change or highly impacting, perhaps we can skip mentioning it?
The points under Major Fixes on @azure/[email protected]
do not seem to be developer impacting changes either. They do not need to react to these changes. I would recommend removing both the Major Fixes
and this current section here and have say just this line
The beta releases has bug fixes to improve quality and support for custom role definitions.
See What is a developer impacting change?
cc @maorleger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a breaking change, but from one beta to another, since this client hasn't been GAd.
BackupResult and RestoreResult from backup/restore long running operations now contain additional information about the operation, we can say that 🤔
@ramya-rao-a @joheredi thank you for your feedback! I'll be working on an update ✌ |
Co-authored-by: Jose Manuel Heredia Hidalgo <[email protected]> Co-authored-by: Ramya Rao <[email protected]>
Regarding the missing highlights:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow up with the missing highlights in a separate PR. We can merge this for now
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
February release notes for JavaScript and TypeScript. Please suggest changes with your release notes. If you're looking for inspiration: - [What's a Developer Impacting Change?](https://github.com/Azure/azure-sdk/blob/08f279b39a4c19822b1509e6b10fc3ce256607b5/docs/policies/releasenotes.md#whats-a-developer-impacting-change). - Highlight guidelines: <https://azure.github.io/azure-sdk/policies_releasenotes.html> - September's PR: Azure#1750 - October's PR: Azure#1878 - November's PR: Azure#2029 - December's PR: Azure#2138 - January's PR: Azure#2240
February release notes for JavaScript and TypeScript.
Please suggest changes with your release notes.
If you're looking for inspiration: