Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

February release highlights for JavaScript & TypeScript #2333

Merged
20 commits merged into from
Feb 13, 2021

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Feb 4, 2021

February release notes for JavaScript and TypeScript.

Please suggest changes with your release notes.

If you're looking for inspiration:

February release notes for JavaScript and TypeScript.

Please suggest changes with your release notes.

If you're looking for inspiration:

- [What's a Developer Impacting Change?](https://github.com/Azure/azure-sdk/blob/08f279b39a4c19822b1509e6b10fc3ce256607b5/docs/policies/releasenotes.md#whats-a-developer-impacting-change).
- Highlight guidelines: <https://azure.github.io/azure-sdk/policies_releasenotes.html>
- September's PR: #1750
- October's PR: #1878
- November's PR: #2029
- December's PR: #2138
- January's PR: #2240
@sadasant sadasant self-assigned this Feb 4, 2021
@witemple-msft
Copy link
Member

@sadasant The phrasing of "changes on" sounds strange to me, and I think we should replace it with "in" in the section headers. ("changes on @azure/[email protected]" -> "changes in @azure/[email protected]"). I'll fill out my notes according to the template here, but this is just some extra feedback.

releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving comments for the Event Hubs package.

releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved
@sadasant
Copy link
Contributor Author

@witemple-msft @chradek @ljian3377 Thank you! I have pushed an update here: ce3ac4b Please review again!

The updates for synapse are very small. I coordinated this with Jonathan!
releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved
@sadasant sadasant marked this pull request as ready for review February 11, 2021 19:37
releases/2021-02/js.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see Search here...

Can we do a check on whether our partners have released anything?

  • Monitor
  • Communications
  • Digital twins
  • Synapse
  • Quantum
  • Attestation

releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved
releases/2021-02/js.md Outdated Show resolved Hide resolved

#### @azure/storage-blob [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/CHANGELOG.md)

##### Major Fixes in @azure/[email protected] ([Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/CHANGELOG.md#1241-2021-02-03))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the changelog link at this level? Wouldnt the changelog link a few lines above suffice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally point to the exact version in the changelog above. In this case we have two, so I thought on separating them.

releases/2021-02/js.md Outdated Show resolved Hide resolved
##### Major Fixes in @azure/[email protected] ([Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/CHANGELOG.md#123-2021-02-09))

- Fixed Azure Stack support for the NodeJS version of the `InteractiveBrowserCredential`.
- The 'keytar' dependency has been updated to the latest version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dependency update is not a release highlight unless it solved a major problem for the customer. I recall the user did have some trouble which required us to do this update. Mentioning that here would help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the original issue: Azure/azure-sdk-for-js#13531

That issue is still open and the real solution is not trivial. This update helps but it's very minor. I'll remove the highlight entry.


##### Major Fixes in @azure/[email protected] ([Changelog](https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/identity/identity/CHANGELOG.md#123-2021-02-09))

- Fixed Azure Stack support for the NodeJS version of the `InteractiveBrowserCredential`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we talk about what the problem before was? If I am an Azure Stack user, I wouldnt know whether this line would apply to me or not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on this?

Fixed a bug that appeared while using InteractiveBrowserCredential to authenticate against Azure Stack from NodeJS (for local apps that would ask for authentication using a browser window). Azure Stack has specific authentication requirements that were missed on our previous InteractiveBrowserCredential release.

releases/2021-02/js.md Outdated Show resolved Hide resolved

##### Changes on @azure/[email protected]

- Backup and restore operations will now return a `BackupResult` and `RestoreResult` as appropriate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was it returning before? Does the user have to change their code? If this is not a breaking change or highly impacting, perhaps we can skip mentioning it?

The points under Major Fixes on @azure/[email protected] do not seem to be developer impacting changes either. They do not need to react to these changes. I would recommend removing both the Major Fixes and this current section here and have say just this line

The beta releases has bug fixes to improve quality and support for custom role definitions.

See What is a developer impacting change?

cc @maorleger

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breaking change, but from one beta to another, since this client hasn't been GAd.

BackupResult and RestoreResult from backup/restore long running operations now contain additional information about the operation, we can say that 🤔

releases/2021-02/js.md Outdated Show resolved Hide resolved
@sadasant
Copy link
Contributor Author

@ramya-rao-a @joheredi thank you for your feedback! I'll be working on an update ✌

releases/2021-02/js.md Outdated Show resolved Hide resolved
sadasant and others added 3 commits February 12, 2021 15:50
@sadasant
Copy link
Contributor Author

sadasant commented Feb 12, 2021

@ramya-rao-a

Regarding the missing highlights:

  • Synapse (& Monitor) was left out because the update didn't seem relevant enough for a highlight when Jonathan and I reviewed the changes.
  • Communications: I have contacted Dominik. to see if they can provide some highlights (Edit: highlights are already in this PR).
  • Digital twins: I have contacted Zoltan.
  • Quantum: I have contacted Victor. (Edit: No highlights needed).
  • Attestation: I have contacted Larry.

Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow up with the missing highlights in a separate PR. We can merge this for now

@ghost
Copy link

ghost commented Feb 13, 2021

Hello @sadasant!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 45c399b into master Feb 13, 2021
@ghost ghost deleted the js-february-highlights branch February 13, 2021 01:45
vhvb1989 added a commit to vhvb1989/azure-sdk that referenced this pull request Feb 19, 2021
February release notes for JavaScript and TypeScript.

Please suggest changes with your release notes.

If you're looking for inspiration:

- [What's a Developer Impacting Change?](https://github.com/Azure/azure-sdk/blob/08f279b39a4c19822b1509e6b10fc3ce256607b5/docs/policies/releasenotes.md#whats-a-developer-impacting-change).
- Highlight guidelines: <https://azure.github.io/azure-sdk/policies_releasenotes.html>
- September's PR: Azure#1750
- October's PR: Azure#1878
- November's PR: Azure#2029
- December's PR: Azure#2138
- January's PR: Azure#2240
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.