Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AZC0004 ensure that method signatures match #9388

Merged
merged 11 commits into from
Dec 11, 2024
+151 −0
Merged

AZC0004 ensure that method signatures match #9388

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c3deaa8
Add new check for ReturnTypes
JonathanCrd Nov 13, 2024
bbfbade
Check for parameters too
JonathanCrd Dec 4, 2024
6168a70
Revert "Check for parameters too"
JonathanCrd Dec 4, 2024
50cf3ee
Check for parameters in both methods
JonathanCrd Dec 4, 2024
0b4834b
Skip check for AMQP libraries
JonathanCrd Dec 9, 2024
1ea800a
Revert "Skip check for AMQP libraries"
JonathanCrd Dec 9, 2024
10a5a0a
Fix AZC0004 tests
JonathanCrd Dec 10, 2024
b86efc4
handle scenario for Pageable types
JonathanCrd Dec 11, 2024
8705bd8
Compare return types recursively
JonathanCrd Dec 11, 2024
4d655ab
nit: scope everything with the not operator
JonathanCrd Dec 11, 2024
90e9d4c
Add tests
JonathanCrd Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/ClientMethodsAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,22 @@ private static bool DoReturnTypesMatch(ITypeSymbol asyncReturnType, ITypeSymbol
else
{
var asyncInnerType = asyncNamedType.TypeArguments.FirstOrDefault();

string asyncInnerTypeName = asyncNamedType.Name;
JonathanCrd marked this conversation as resolved.
Show resolved Hide resolved

return SymbolEqualityComparer.Default.Equals(asyncInnerType, syncReturnType);

}
}

// Add scenario to handle AsyncPageable<T> and Pageable<T> return types
if (asyncReturnType is INamedTypeSymbol asyncNamedTypeSymbol && asyncNamedTypeSymbol.IsGenericType && asyncNamedTypeSymbol.Name == AsyncPageableTypeName)
{
if (syncReturnType is INamedTypeSymbol syncNamedTypeSymbol && syncNamedTypeSymbol.IsGenericType && syncNamedTypeSymbol.Name == PageableTypeName)
{
var asyncInnerType = asyncNamedTypeSymbol.TypeArguments.Single();
var syncInnerType = syncNamedTypeSymbol.TypeArguments.Single();
return SymbolEqualityComparer.Default.Equals(asyncInnerType, syncInnerType);
}
}

Expand Down
Loading